Dawnline 0.6.0
- Access rules fail closed: when the table cannot load, no device is loaded into the tunnels (the firewall alone would let every loaded device reach everything); an older table that survived a failed rebuild keeps its rules and a revoked device still leaves. The agent re-syncs within a minute when the table is gone - A change the router saved but could not put into effect (access rules that did not load, a server that refused its devices) is said in the admin UI instead of a plain "Saved" - The guard judges every packet, not only a connection's first: a change of access, a pause or a limit now cuts open connections too - Each server's home networks are its own: with several servers, "all home" on one no longer reaches the other's networks where firewall zones overlap - People limited to some home networks reach the router only on the addresses in those networks (LuCI and SSH on the main LAN stay closed) - Internet-only people can open their personal portal with the VPN on - Tunnel DNS reaches the resolver and the LAN's DNS from servers that do not forward to those zones on their own (Home-only names on servers without "like a home device", LAN DNS on servers with no home network) - A new personal link offers to remove the devices added through the old one, so a leaked link is really contained - Import and restore refuse an inconsistent file (devices with addresses outside their server, shared addresses, malformed keys, broken references); Health reports one, and the sync leaves such a device out instead of failing its server. A config write that did not reach flash is an error, not a silent success - Backups are kept per kind (nightly ones no longer push out manual or pre-delete ones), nightly and pre-change backups hold the config only, archives are written whole or not at all, and a failed nightly backup is logged. A restore no longer has its history overwritten by the agent's in-memory counters - Settings defaults and ranges come from one place (dawnline.schema) - Portal: anything not shaped like a personal link is answered by a shell before ucode starts (a scan on the root costs nothing); 4 portal processes at once instead of 16; a link may make 40 changes a quarter hour; over plain HTTP the page shows but configurations, new devices and new keys are refused with the HTTPS twin of the link; the connect sheet polls only while the first connection is awaited, with backoff, and stops once the link stopped working - Updates: after Dawnline's own package changes, a shell checks that LuCI reaches it and the agent runs, and puts the kept previous version back when they do not (automatic runs always keep it); the AmneziaWG module reload verifies rmmod and modprobe; installs check free space; on apk a reinstall that changed nothing is an error; uninstall.sh hands the update lock to the removal it calls; an upgrade restarts the service only where it was enabled; the release workflow pins the SDK images by digest and the actions by commit - AmneziaWG: features count only when both the tools and the kernel module have them; a server whose disguise this build cannot run (a 3.1 preset after a rollback to 2.0) is kept down and reported; Components tells 1.0 builds from 2.0 ones; `awg show dump` is parsed by shape; Maximum's DNS-shaped signature packets are made for each server and its keep-alive is a 25-35 s range - CI compiles every ucode file and runs the new tests/ucode unit tests (54 tests on the real libuci) in OpenWrt 24.10 and 25.12 rootfs containers; scripts/compile-ucode.sh does the same wherever ucode runs and scripts/ucode-container.sh locally with docker; lint-ucode checks POSIX regexes and module layering; a tag builds only after CI passes
This commit is contained in:
1 parent
2b98abdba4
commit
31a2065f05
70 files changed
+2008
-307
No files matched your search
+43
-5
@@ -3,8 +3,10 @@
|
||||
|
||||
ucode resolves names where they are used: calling a function that is declared
|
||||
further down the same file fails at runtime ("access to undeclared variable").
|
||||
Also: calls and named imports must match what a Dawnline module exports, and
|
||||
the rpcd methods (dawnline.rpc.*) must match the plugin and its ACL.
|
||||
Also: calls and named imports must match what a Dawnline module exports, the
|
||||
rpcd methods (dawnline.rpc.*) must match the plugin and its ACL, and regexes
|
||||
stay POSIX (rules/backend.md). Imports against the module layering are
|
||||
reported as notes, not failures.
|
||||
Run: scripts/lint-ucode.py [package root]
|
||||
"""
|
||||
import glob
|
||||
@@ -22,9 +24,8 @@ files = modules + [
|
||||
PLUGIN,
|
||||
f"{root}/usr/libexec/dawnline/agent",
|
||||
f"{root}/usr/libexec/dawnline/updater",
|
||||
f"{root}/usr/libexec/dawnline/resolver",
|
||||
f"{root}/usr/bin/dawnline",
|
||||
f"{root}/usr/share/dawnline/portal/www/cgi-bin/portal",
|
||||
f"{root}/usr/share/dawnline/portal/cgi.uc",
|
||||
]
|
||||
files = [f for f in files if os.path.exists(f)]
|
||||
bad = 0
|
||||
@@ -40,6 +41,16 @@ def strip_comments(text):
|
||||
return re.sub(r'//[^\n]*|/\*.*?\*/', '', text, flags=re.S)
|
||||
|
||||
|
||||
def blank_comments(text):
|
||||
"""Comments replaced by their newlines: line numbers stay, their text goes."""
|
||||
return re.sub(r'//[^\n]*|/\*.*?\*/', lambda m: '\n' * m.group(0).count('\n'), text, flags=re.S)
|
||||
|
||||
|
||||
# A regex literal on one line: `/…/` with no slash inside, followed by flags or
|
||||
# a delimiter (so a division keeps out). Good enough for how Dawnline writes them.
|
||||
REGEX_LITERAL = re.compile(r'(?<![\w)\]])/((?:\\.|[^/\\\n])+)/[gis]*(?=[,);\s])')
|
||||
|
||||
|
||||
def modname(path):
|
||||
"""dawnline/rpc/people.uc → 'rpc.people' (as in import … from 'dawnline.rpc.people')."""
|
||||
rel = os.path.relpath(path, MODDIR)[:-3]
|
||||
@@ -55,7 +66,7 @@ for f in files:
|
||||
problem(f"{f}:{line}: {name}() is used before its definition")
|
||||
# In a module an exported function is an expression statement: its closing
|
||||
# brace needs a semicolon ("Expecting ';'" breaks the whole module).
|
||||
lines = open(f, encoding='utf-8').read().split('\n')
|
||||
lines = blank_comments(open(f, encoding='utf-8').read()).split('\n')
|
||||
inside = None
|
||||
for n, text in enumerate(lines, 1):
|
||||
if inside is None and re.match(r'^export function \w+\(', text):
|
||||
@@ -68,6 +79,14 @@ for f in files:
|
||||
# not preceded by valid expression"), and let [a, b] = … does not compile.
|
||||
if re.search(r'/[^/\n]*\(\?[:=!][^/\n]*/', text):
|
||||
problem(f"{f}:{n}: ucode regexes are POSIX: no (?: (?= (?! groups")
|
||||
# Lazy quantifiers (*? +? }?) and the [\s\S] class are PCRE: the C
|
||||
# library's regcomp does something else with them or rejects them.
|
||||
for m in REGEX_LITERAL.finditer(text):
|
||||
body = m.group(1)
|
||||
if re.search(r'(?<!\\)[*+}]\?', body):
|
||||
problem(f"{f}:{n}: ucode regexes are POSIX: no lazy quantifiers (*? +? }}?) in /{body}/")
|
||||
if re.search(r'\[\\[sS]\\[sS]\]', body):
|
||||
problem(f"{f}:{n}: ucode regexes are POSIX: no [\\s\\S] class in /{body}/ (use (.|\\n) or a negated class)")
|
||||
if re.match(r'\s*(let|const)\s*[\[{]', text):
|
||||
problem(f"{f}:{n}: ucode has no destructuring")
|
||||
|
||||
@@ -124,5 +143,24 @@ if methods and os.path.exists(ACL):
|
||||
if 'uci' in acl.get(kind, {}) and 'dawnline' in acl[kind]['uci']:
|
||||
problem(f"{ACL}: {kind} grants uci 'dawnline' (private keys, no validation): use the rpc methods")
|
||||
|
||||
# Layering (rules/backend.md): util, schema → core → store → domain modules →
|
||||
# apply → entry points. A module importing one from a layer above it is
|
||||
# reported, not failed, until the existing edges are untangled.
|
||||
LAYER = {'util': 0, 'schema': 1, 'core': 2, 'store': 3, 'apply': 5}
|
||||
LAYER_NAME = {0: 'util', 1: 'schema', 2: 'core', 3: 'store', 4: 'domain', 5: 'apply'}
|
||||
notes = 0
|
||||
for f in modules:
|
||||
mod = modname(f)
|
||||
if mod.startswith('rpc.'):
|
||||
continue # an entry point: may import anything
|
||||
mine = LAYER.get(mod, 4)
|
||||
for dep in re.findall(r"from 'dawnline\.([\w.]+)'", strip_comments(open(f, encoding='utf-8').read())):
|
||||
theirs = LAYER.get(dep, 4)
|
||||
if theirs > mine or (theirs == mine and mine < 4 and dep != mod):
|
||||
print(f"note: {f}: {mod} ({LAYER_NAME[mine]}) imports dawnline.{dep} ({LAYER_NAME[theirs]}), a layer above it")
|
||||
notes += 1
|
||||
if notes:
|
||||
print(f"lint-ucode: {notes} layering notes (not failures)")
|
||||
|
||||
print(f"lint-ucode: {len(files)} files checked" + (", problems found" if bad else ", ok"))
|
||||
sys.exit(bad)
|
||||
Reference in new issue
Block a user